search

beached / json_to_cpp

Generate C++ class from JSON data
Boost Software License 1.0
47 stars 4 forks source link

seems this can't compile anymore after changes to utf_range being made header only #1

Closed qwertynat closed 4 years ago

qwertynat commented 4 years ago

on a fresh clone this fails to link, it is looking for -utf_range -ltemp_file

which are now header only i think

beached commented 4 years ago

Ill see what I can do to get it building. The dependent code bases have had a lot of changes and I think for now I need to fix the version used to an older revision. Once v2 is done with daw_json_link I planned to make some big changes to json_to_cpp so that it can generate newer binding code.

beached commented 4 years ago

Should be fixed now. utf_range was made optionally header only outside "this" project nothing uses the binary and it was adding build time. And temp_file was made header only but it wasn't relected here. Was able to do a clean make build

qwertynat commented 4 years ago

gets further, however a (final) error

[100%] Linking CXX executable json_to_cpp /usr/bin/ld: /home/nathan/src//TEST/json_to_cpp/build/install/lib/libutf_string.a(daw_utf_string.cpp.o): in function daw::utf_string::to_u32string[abi:cxx11]() const': daw_utf_string.cpp:(.text+0x54f): undefined reference todaw::range::utf_range::to_u32string[abi:cxx11]() const' collect2: error: ld returned 1 exit status gmake[2]: [CMakeFiles/json_to_cpp.dir/build.make:120: json_to_cpp] Error 1 gmake[1]: [CMakeFiles/Makefile2:138: CMakeFiles/json_to_cpp.dir/all] Error 2 gmake: *** [Makefile:161: all] Error 2

beached commented 4 years ago

did you clean the cmake build, might need to recreate the build folder? there were defines added to two projects in their cmake config.

qwertynat commented 4 years ago

just tried my desktop instread of laptop, both, fedora32. same error.

beached commented 4 years ago

Found it, I don't know how it worked but MacOS is odd too. It was missing a target library. Was able to make it work in ubuntu after seeing that error

Probably why my other projects have got CI and this one will in the future too

qwertynat commented 4 years ago

yeah all good here as well.

many thanks!

beached commented 4 years ago

Awesome. The plan is a rewrite using daw_json_link as the basis, it is much faster while the current parse_json dep is really old and slow.