search

beamer-bridge / beamer

Beamer - Bridging rollups with L1 inherited security
https://beamerbridge.com
MIT License
45 stars 21 forks source link

beamer: config: remove chain from dictionary if reset to default values #2149

Closed fredo closed 1 year ago

fredo commented 1 year ago

The same thing was missing for chains.

Removing chains should result in removing it from the dicitonary.

istankovic commented 1 year ago

Seems good to me, checked if we have any tests regarding Token removal and couldnt find any so this should be also ok

Should we not then use this opportunity to add new tests, both for token and chain removal? :smile: Especially since it seems like an easy thing to do.

It would also be interesting to see test coverage now for modules under beamer.config.

fredo commented 1 year ago

Should we not then use this opportunity to add new tests, both for token and chain removal? 😄 Especially since it seems like an easy thing to do.

There you go