Closed nicholasjhorton closed 8 years ago
Much of the vignette is hard to follow. It would be helpful if it were simplified and made more linear. Some suggestions:
1) there are two examples of creating SQLite databases at the beginning, without clarity about what the difference is between the two calls
2) I'd suggest removing 'airlines <- etl("airlines")' entirely and hardcoding where the db file should be created.
3) I'd suggest a separate MySQL example that starts from the beginning (make two parallel vignettes?)
4) move discussion of init script and schema as a note at the end of the vignette
5) move the discussion of getS3method("etl_update", "default") and getS3method("etl_create", "default") to a note at the end of the vignette
6) move all of the discussion of etl_extract() out of the main vignette (and into a note
7) suggest changing:
airlines <- etl("airlines", db)
to
airlines <- etl("airlines", db) # create airlines database using the commands from the airlines package
Much of the vignette is hard to follow. It would be helpful if it were simplified and made more linear. Some suggestions:
1) there are two examples of creating SQLite databases at the beginning, without clarity about what the difference is between the two calls
2) I'd suggest removing 'airlines <- etl("airlines")' entirely and hardcoding where the db file should be created.
3) I'd suggest a separate MySQL example that starts from the beginning (make two parallel vignettes?)
4) move discussion of init script and schema as a note at the end of the vignette
5) move the discussion of getS3method("etl_update", "default") and getS3method("etl_create", "default") to a note at the end of the vignette
6) move all of the discussion of etl_extract() out of the main vignette (and into a note
7) suggest changing:
airlines <- etl("airlines", db)
to
airlines <- etl("airlines", db) # create airlines database using the commands from the airlines package