beardypig / streamlink-portable

A script to build a portable version of Streamlink for Windows
Apache License 2.0
77 stars 18 forks source link

"Build nightly" workflows currently failing :-( #22

Closed Vangelis66 closed 3 years ago

Vangelis66 commented 3 years ago

Hi πŸ˜„

A recent upstream change, cli: rename config file on Windows to "config" now causes build nightly workflow runs to fail,

https://github.com/beardypig/streamlink-portable/actions/runs/912990920

https://github.com/beardypig/streamlink-portable/actions/runs/916706541

because file streamlinkrc is no longer found:

7. Build win32 package

Run bash ./scripts/makeportable.sh
[makeportable.sh] Downloading Python 3.7.9 win32...
[makeportable.sh] Downloading Python dependencies...
[makeportable.sh] Building streamlink sdist
no previously-included directories found matching 'docs/_build'
warning: no files found matching 'docs/_build/man/*'
no previously-included directories found matching '*/__pycache__'
warning: no previously-included files matching '*.pyc' found anywhere in distribution
warning: no previously-included files matching '*~' found anywhere in distribution
warning: no previously-included files matching '*.bak' found anywhere in distribution
warning: no previously-included files matching '*.swp' found anywhere in distribution
warning: no previously-included files matching '*.pyo' found anywhere in distribution
[makeportable.sh] Unpacking python
[makeportable.sh] Unpacking Windows 10 Universal Runtime
[makeportable.sh] Unpacking wheels
cp: cannot stat '/home/runner/work/streamlink-portable/streamlink-portable/streamlink/win32/streamlinkrc': No such file or directory
Error: Process completed with exit code 1.

I suspect the same ill fate awaits Build new release workflows when they are actually executed... πŸ˜‰ 😞

As mentioned several times in the past, I exclusively use your own portable 32-bit packages here, last successful build was streamlink-2.1.2+29-git-20210605-ge39bc5e-py3.7.9-win32-portable-gb5092bb from ca. 3 days ago...

Can you please fix this latest breakage? I'd be overly grateful if you did...

Best regards πŸ˜„

WolfganP commented 3 years ago

Same here. I was looking for the portable build of v2.2.0 and noticed the action failing due to the changes related to streamlinkrc removal.

It seems corrected in https://github.com/chhe/streamlink-portable/commit/97b81485468572ac22b64a5951d1d718c3ce4c5f but couldn't test it.

Vangelis66 commented 3 years ago

@beardypig

Apologies for bumping this, but can you please, at least, give us a time frame on when, ultimately, a fix will be applied to restore the portable streamlink builds? Streamlink itself has already moved to v2.2.0+10-git-20210623-g0702966 as of this writing, portable is stuck at 2.1.2+29-git-20210605-ge39bc5e ... 😿

Thank you for any input... πŸ˜‰