search

beast-dev / tracer

Posterior summarisation in Bayesian phylogenetics
https://beast.community/tracer
GNU Lesser General Public License v2.1
55 stars 17 forks source link

Traces with the same name in the same trace file #35

Closed rambaut closed 7 years ago

rambaut commented 7 years ago

The first one with the name is shown. Need to add a suffix number to the trace name on loading.

walterxie commented 7 years ago

@rambaut Can you give more details? I do not think we should allow the same name given to different parameters logged in the same log file.

rambaut commented 7 years ago

I don't think we should disallow it. Just append a number.

walterxie commented 7 years ago

Because this equals to allow the same names for different variables in one function. I cannot think of any motivation to implement this. If a BEAST log duplicates parameters, then we should fix the logging bug, instead to let it pass to post-analysis.

rambaut commented 7 years ago

My philosophy with software is to not annoy the user. If they want to load a file with identical column headings, then let them. By putting this in the issue list, I wasn't suggesting you need to implement it.

mtolkoff commented 7 years ago

It's not always a logging bug. For example if you name your parameters "parameter1" ... "parameter15" and each of these parameters is of length 15, then it's ambiguous whether "parameter115" is the 5th element of parameter 11 or the 15th element of parameter1. You can solve this by changing the parameter scheme to be "parameter11.5" for example, but that precludes the user for including another parameter named "parameter11.5" elsewhere in the XML.

On Tue, Mar 14, 2017 at 2:56 PM, Walter notifications@github.com wrote:

Because this equals to allow the same names for different variables in one function. I cannot think of any motivation to implement this. If a BEAST log duplicates parameters, then we should fix the logging bug, instead to let it pass to post-analysis.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/beast-dev/tracer/issues/35#issuecomment-286573770, or mute the thread https://github.com/notifications/unsubscribe-auth/ALlJeaI_2C6n45B5xb5yyVqVrUOqS20vks5rlw0lgaJpZM4Makqo .

rambaut commented 7 years ago

It is currently a bug as it neither deals with the issue (by appending numbers) or disallows identical trace names. It also has unexpected and erroneous behaviour.