beastsaber / bsaber

https://bsaber.com
9 stars 9 forks source link

Fix pagination issue in a hacky way #134

Closed TimothyGillespie closed 4 months ago

TimothyGillespie commented 4 months ago

Solves #133. I personally don't like the solution, but for some reason not using external - and thus forcing svelte to completely load the website instead of SPA navigating - just didn't yield results. There is very likely a better way to solve this, but I didn't find it and I expect it to be quite the time sink. I've sunk a bit of time into debugging this without finding a better solution.

The event card's each-iteration are keyed and the card div event receives an id. But that oddly doesn't seem to do the trick.

I think from the user perspective this hack works well enough. The difference between a complete refresh and SPA navigation is probably only noticable with slow Internet.

We could make a ticket for looking into and improving this.

netlify[bot] commented 4 months ago

Deploy Preview for bsaber ready!

Built without sensitive environment variables

Name Link
Latest commit 74ed2515705c56acf407ca88fbb40830c2c95fe8
Latest deploy log https://app.netlify.com/sites/bsaber/deploys/6647a180dfbe690008bcf36c
Deploy Preview https://deploy-preview-134--bsaber.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.