search

beastsaber / bsaber

https://bsaber.com
9 stars 9 forks source link

Add authors to posts #138

Closed TimothyGillespie closed 4 months ago

TimothyGillespie commented 4 months ago

Revival of #50. Solves #92.

netlify[bot] commented 4 months ago

Deploy Preview for bsaber ready!

Built without sensitive environment variables

Name Link
Latest commit d81d6192abe4237945ce7ec5b81327c2a57e894b
Latest deploy log https://app.netlify.com/sites/bsaber/deploys/664b40fc2783dd0008364891
Deploy Preview https://deploy-preview-138--bsaber.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

TheCzar1994 commented 4 months ago

Everything looks great to me but would need a second set of eyes to double check the code. Would need to remove the test data before merging.

TimothyGillespie commented 4 months ago

Btw, I did find a bug with this PR. For some reason it cannot show multiple authors. I spend some time to debug it, but no dice so far. It only shows the first. The data just doesn't seem to reach the frontend for some reason, but everything works as expected. I wanted to highlight that, but I'd suggest making an issue out of it as I'm currently at a loss for that one while it doesn't seem to break anything majorly.

This is what multiple authors would look like though: image