AI-3786: Fix tests for attachment type fields

bedatadriven / activityinfo-R

ActivityInfo R Language Client

https://www.activityinfo.org/support/docs/R/

17 stars 12 forks source link

AI-3786: Fix tests for attachment type fields #105

Closed jamiewhths closed 8 months ago

jamiewhths commented 8 months ago

AI-3786: Update attachmentFieldSchema to use new attachment field type parameters

Form field tests on R package require identical request and response JSON for form fields
Therefore must update R package test to use new attachment type structure (notably removing "kind" property and including "captureMethods" property)
However attachment type deserialisation remains backwards compatible, so users who pass in old structure will not be blocked by the changes to attachment type

jamiewhths commented 8 months ago

@akbertram we need to update this test for AI-3786 to pass tests and to therefore merge to production. However I guess this will make the GitHub test pipeline fail as a result. Let me know how you want to handle this.