bedrock-tool / bedrocktool

a mostly working minecraft bedrock tool for downloading server worlds, skins and others
GNU General Public License v3.0
188 stars 22 forks source link

some crashing issues #173

Closed ghost closed 6 months ago

ghost commented 6 months ago

Whenever i connect to a server for the first time, it either says:

read packet minecraft 192.168.1.9:63422->15.235.212.9:19132: Please check your connection. image

or

write packet minecraft 192.168.1.9:51483->139.99.4.169:19132: Please check your connection. image

And the gui crashes. However, opening the gui and connecting to the server for the second time, it does work, but when you either try to save the world, or transfer to a different proxy server, the connection and file crashes

Here's the log for that second try:

time="2024-05-01T18:15:11+08:00" level=info msg="Saving world Hive Games with 212 Chunks" panic: runtime error: invalid memory address or nil pointer dereference [signal 0xc0000005 code=0x0 addr=0x38 pc=0x1952b32]

goroutine 45 [running]: github.com/df-mc/dragonfly/server/world/mcdb.(DB).SaveLocalPlayerData(0x0, 0x0?) /home/runner/work/bedrocktool/bedrocktool/dragonfly/server/world/mcdb/db.go:114 +0xb2 github.com/bedrock-tool/bedrocktool/handlers/worlds/worldstate.(World).Finish(, , {, , }, , {0x0, 0x20, 0x0}, {{0xc000f04400, ...}, ...}, ...) /home/runner/work/bedrocktool/bedrocktool/handlers/worlds/worldstate/world.go:400 +0x8ac github.com/bedrock-tool/bedrocktool/handlers/worlds.(worldsHandler).saveWorldState(0xc0002649a0, 0xc0014c1790) /home/runner/work/bedrocktool/bedrocktool/handlers/worlds/world.go:428 +0x4bc github.com/bedrock-tool/bedrocktool/handlers/worlds.(worldsHandler).SaveAndReset.func1() /home/runner/work/bedrocktool/bedrocktool/handlers/worlds/world.go:402 +0x4f created by github.com/bedrock-tool/bedrocktool/handlers/worlds.(*worldsHandler).SaveAndReset in goroutine 23 /home/runner/work/bedrocktool/bedrocktool/handlers/worlds/world.go:400 +0x294