beegee-tokyo / SX126x-Arduino

Arduino library to use Semtech SX126x LoRa chips and modules to communicate
MIT License
236 stars 64 forks source link

Allow for different TCXO control voltages #82

Closed dberlin closed 1 year ago

dberlin commented 1 year ago

Currently the TCXO control voltage is hard coded to 3.3v.

For some boards, like the heltec lora v3 boards, they are using 1.8V

See https://github.com/Heltec-Aaron-Lee/WiFi_Kit_series/blob/master/esp32/libraries/LoraWan102/src/driver/sx126x.c#L79

It would be nice if it was possible to pass along the TCXO control voltage in the setup struct.

dberlin commented 1 year ago

83 implements this

beegee-tokyo commented 1 year ago

Nice extension to the functionality. Thank you for submitting. I will have a quick test this weekend and merge it.