search

beeldengeluid / dane-video-segmentation-worker

0 stars 0 forks source link

13 manage edge cases for spectograms quick dirty #22

Closed Veldhoen closed 1 year ago

Veldhoen commented 1 year ago

Implemented #13 and added unit test

Veldhoen commented 1 year ago

Test fails, if I understand correctly, on obtaining value from config: SPECTOGRAM_WINDOW_SIZE_MS: 1000 from VISXP_PREP. The value does exist in this branch though: https://github.com/beeldengeluid/dane-video-segmentation-worker/blob/13-manage-edge-cases-for-spectograms-quick-dirty/config/config.yml How do I fix this?

jblom commented 1 year ago

@Veldhoen until now the unit tests did not require the config.yml. Inside the GitHub actions container this was not avialable yet. Now added the following block (to .github/workflows/_test.yml) to ensure it's there:

- name: "test"
      run: |
        cp config_test.yml config.yml
        poetry run pytest
jblom commented 1 year ago

@Veldhoen the code looks fine (test looks ok for now & works) and since it's not in the way of anything I'll merge it. (we can always decide to leave out the edge case checking or move it elsewhere)