Small optimizations and additions.

[andrimarjonsson]

• Added length property to CPToken: All the data is already there when tokenising, this simply stores that result in the token since I'm experimenting with using CoreParse for syntax highlighting.
• Changed install path to @rpath. Reasoning for this is to leave the decision to the user of the library. Numerous articles online on the benefits of using @rpath.
• Implemented caching for delegate responses resulting in a small speedboost.

[beelsebob]

Hiya, that looks like a really good set of patches. The only issues I can see are that setDelegate: on CPParser appears not to actually set the delegate (only do the caching). And a tiny style issue – it would be nice if you could typedef the two introduced structs, and use the new type to declare them.

I guess I should add a pair of tests to check that setting the delegate actually sets it.

Thanks

Tom Davie

[andrimarjonsson]

Wow, you are right. Well that's a bit embarrassing. See you have already merged, guessing you are then fixing the bugs I introduced along with these changes. If not I can do it tomorrow evening, no problem!

Sorry for not replying earlier. Day job and all.

[beelsebob]

No probs at all,

They gave a nice little speed gain. You may have noticed that I've been working on my own optimisations too, so parsing should now be roughly twice as fast as it was before.

Tom Davie

On 23 Aug 2012, at 23:31, Andri Mar Jónsson notifications@github.com wrote:

Wow, you are right. Well that's a bit embarrassing. See you have already merged, guessing you are then fixing the bugs I introduced along with these changes. If not I can do it tomorrow evening, no problem!

Sorry for not replying earlier. Day job and all.

— Reply to this email directly or view it on GitHub.