beeware / batavia

A JavaScript implementation of the Python virtual machine.
http://pybee.org/batavia
Other
1.39k stars 424 forks source link

Console scroll bar stays bottom when exceeds maximum height #699

Closed Boeing737ng closed 6 years ago

Boeing737ng commented 6 years ago

------------------------------- Describe your changes in detail ----------------------------------- Added the code (this.element.scrollTop = this.element.scrollHeight) for the scrollbar to stay bottom when the console output results exceed the console box's maximum height.

----------------------------- What problem does this change solve? ----------------------------- As it is mentioned in issue #698 , Scrollbar of console output just stayed top even though the results' height is longer than the console box maximum height. Now it focuses bottom(last result) when the results exceed box's maximum height just like any other code editors' console.

------------------------------------------- Fixed issue ------------------------------------------- It Fixes #698 .

Boeing737ng commented 6 years ago

@freakboy3742 Could you try running the project with this change? It's a simple change but the console scroll action supposed to work like this.