Fix for 'cricket-unttest run all' 922+ Fails [Window] #685 - Githubissues

beeware / batavia

A JavaScript implementation of the Python virtual machine.

http://pybee.org/batavia

Other

1.39k stars 424 forks source link

Fix for 'cricket-unttest run all' 922+ Fails [Window] #685 #704

Closed smitar0y closed 6 years ago

smitar0y commented 6 years ago

Many unit test is failing in windows due to line separator issue. The test fail with assertion error having extra /// or ||| in the string output. As per liefr

"It seems like the output from javascript does not respect the native line separator difference. Changing it to: lines1 = code1.split('\n')"

As discussed with freakboy3742 implementing these changes.

Refer issue 685 https://github.com/pybee/batavia/issues/685

PR Checklist:

[x ] All new features have been tested
[ ] All new features have been documented
[x ] I have read the CONTRIBUTING.md file
[ x] I will abide by the code of conduct