Update moment (GitHub Security Notification)

beeware / batavia

A JavaScript implementation of the Python virtual machine.

http://pybee.org/batavia

Other

1.39k stars 424 forks source link

Update moment (GitHub Security Notification) #720

Closed glasnt closed 6 years ago

glasnt commented 6 years ago

Security notification for moment means we need to update our dependency

This should pass CI, but best to check

PR Checklist:

[ ] All new features have been tested
[ ] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

glasnt commented 6 years ago

Rebased, forced another build. Hopefully this time it runs clean

glasnt commented 6 years ago

🤷‍♀️

No idea what's going on here. But this needs to be merged because moment really needs upgrading

glasnt commented 6 years ago

For the records: this was failing because I manually updated package.json and package-lock.json without changing the hash for the package. Thus, integrity checks failed, and the js failed to compile, thus all the tests were failing because there was no js to check against.

Next time: update the package.json, npm install, and commit the updated package-lock.json ✨