search

beeware / toga

A Python native, OS native GUI toolkit.
https://toga.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
4.3k stars 668 forks source link

Add default Full Screen command #2865

Open hyuri opened 2 days ago

hyuri commented 2 days ago

What is the problem or limitation you are having?

Much like #796, the default Full Screen shortcut(s) is(are) missing. Toga does not send the app into Full Screen when the default platform keyboard shortcut for Full Screen is pressed. (tested on macOS)

On macOS, two shortcuts are available by default: Command + Control + F and Fn + F. On Windows and Linux, it's F11.

Describe the solution you'd like

Make the default platform keyboard shortcut for Full Screen trigger Full Screen.

Describe alternatives you've considered

None

Additional context

No response

freakboy3742 commented 2 days ago

Makes sense. We might need to wait until #2473 is finalised before it's possible to implement this, though.

The implementation on macOS would be a menu item View > Enter Full Screen with the shortcut (Fn + F). That menu item should change text to "Exit Full Screen" when you're in full screen mode.

I don't have access to my Windows and GTK boxes right now, so I can't confirm what an appropriate menu rendition on Windows or GTK would be.