Closed philschatz closed 6 years ago
Thanks so much for opening your first PR here!
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.
Hi @philschatz! Thanks for your contribution! Although, currently if the cnfig were null, that error would be handled by the catch section, I'm not opposed to being more explicit. I think it might be better to simply check if ( config )
as opposed to if (config != null )
to cover more possibilities. Once changed, I'd be happy to merge this in!
Congrats on merging your first pull request here! :tada: How awesome!
context.config('config.yml')
may return null in some cases (for example, https://github.com/probot/probot/blob/master/lib/context.js#L112 ).This ensures that the
config
is non-null before checking ifnewIssueWelcomeComment
is set.