belav / csharpier

CSharpier is an opinionated code formatter for c#.
https://csharpier.com
MIT License
1.43k stars 99 forks source link

Better support for dotnet commands. #1188

Closed belav closed 9 months ago

belav commented 9 months ago

This makes use RiderDotNetActiveRuntimeHost to find the path to the dotnet exe, and sets DOTNET_ROOT where appropriate. This should remove any need for the PATH to be correct.

closes #893

belav commented 9 months ago

@JSanchezIO I made changes to hopefully remove any PATH issues from Rider. VSCode was having PATH issues for some users, possibly because it never got the changes you had made to Rider.

When updating Rider with similar changes I was reminded that you had fixed the PATH issues on OSX. If you have a chance, would you be able to make sure https://github.com/belav/csharpier/releases/tag/rider-1.6.0-beta works on OSX? Everything is good on windows, and I have an Ubuntu setup I can test them on.

belav commented 9 months ago

Tested this on ubuntu and I believe it is good.