Open pvdbosch opened 3 days ago
Where do you see InputValidationIssues.java fit in? In the problem library or in the validation library?
Good point, I'd put at least the standardized business-agnostic issue types in rest-problem-java (like referencedResourceNotFound).
Not sure about the business-specific ones (like replacedSsin and canceledSsin). It's a bit the same discussion about whether they should be included in the REST guide. Maybe best in the validation library where they can evolve with the validations themselves. Then again, they might be reusable by other validation libraries as well, but that's probably a rather theoretical advantage.
As was mentioned in https://github.com/belgif/rest-guide/issues/169, there are some concerns of combining the validation logic of (business) values with the problem library.
I'd suggest to spin this off to a separate project because:
Some differences with the smalsutils-validation library:
Ideally, we could have a single validation logic for Java and integrate with different ways of using it (programmatic validation, bean validation, inside or outside a REST API context, ...)