search

belgif / thematic

ICEG: Thematic Working Groups
11 stars 5 forks source link

LangString object type #99

Closed bfrichet3 closed 1 year ago

bfrichet3 commented 1 year ago

Dear

I have two problems concerning LangString object type:

1) Propreties of LangString object type (https://belgif.github.io/thematic/models/building/index_en.html#Langstring) are not defined in that datamodel. For me this should be done. One should add propreties shuch as "language" and "spelling" with cardinality [1]. The range of the first property is to be coded value (nl-fr-de-en) as the second is to be string.

Moreover, if one aims to produce qualitative data we should give him the opportunity to describe the source of the specific spelling (like archive document or Ferraris Map or something like that). I would like to add such a property source [0-1]. The range is to be string.

2) In the UML schema we can clearly see that all the classes are spelled like that CamelCase. It's also the case of LangString. Nevertheless, it isn't the case here: https://belgif.github.io/thematic/models/building/index_en.html#Langstring. Could you harmonize that?

Regards

yarondassonneville commented 1 year ago

Thank you for the comment. Indeed, this was a mistake. In a new version of the model we already adapted this issue.

bfrichet3 commented 1 year ago

Ok perfect. I am waiting for your updated model's specifications

bahimc commented 1 year ago

Changes will be made in the next version to be published. Therefore, I'm closing this issue.

bfrichet3 commented 1 year ago

dear @bahimc , as I wrote in the initial post I would appreciate if we add an attribute related to the source of the GeographicalName/LangString object. In the INSPIRE perspective we should use sourceOfName (https://inspire.ec.europa.eu/documents/Data_Specifications/INSPIRE_DataSpecification_GN_v3.0.pdf: page 17)