Closed msramalho closed 2 years ago
Thanks - my PR is coming today!
Wow - some great work in here! I can't immediately see why the google drive code errored. It does look like it saved some files up there successfully. Have emailed you directly about a problem with tiktok-downloader repo. Once that is running I may be able to get this working and test out the GD implementation problems.
Are you going to merge this into dev and we can work from there?
The bug @loganwilliams found with the gd storage + twitter archiver was related to the generate_media_page
which was calling get_cdn_url
before the file was uploaded, and GDStorage, unlinke S3, will not be able to get the URL before uploading.
fixed by removing this line: 6499161
(#33) (the line was duplicated below, where it could actually be called)
All bugs and change requests have been fixed and applied, thanks a lot for the useful feedback, the example.config.yaml is now clearer
Breaking changes.
sheet_name/tab_name
now that's the default but each link can go to a custom folder if providedtried to move all path calculations to
os.path
operations instead of string concatAfter this, deployed versions should do
pipenv update
+ remove anon file,