Show parent comments on /comments

bellroy / lesswrong-migrated

Automatically exported from code.google.com/p/lesswrong

Other

0 stars 0 forks source link

Show parent comments on /comments #301

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Add a preference to user preferences (http://lesswrong.com/prefs/) like:

Comment options [ ] Show parent comments on /comments

(unchecked by default)
When checked, show comments on http://lesswrong.com/comments per attachment 
(show parent comment, comment nested under it, and any replies to comment 
collapsed)

Original issue reported on code.google.com by Matthew.Fallshaw on 5 Jun 2012 at 4:18

Attachments:

[Estarlio comments on Welcome to Less Wrong! (2012) - Less Wrong.png](https://storage.googleapis.com/google-code-attachments/lesswrong/issue-301/comment-0/Estarlio comments on Welcome to Less Wrong! %282012%29 - Less Wrong.png)

GoogleCodeExporter commented 9 years ago

One modification: when checked, please also make the comments show like this 
for comments that come to the user's inbox.

Original comment by lukep...@gmail.com on 5 Jun 2012 at 6:09

GoogleCodeExporter commented 9 years ago

Issue 134 has been merged into this issue.

Original comment by Matthew.Fallshaw on 11 Jun 2012 at 10:10

GoogleCodeExporter commented 9 years ago

Eliezer's comment from #134:

Combined with #129 (making "Reply" work from /comments) this would enable
people to handle full conversations much more easily from within the
/comments page.

Original comment by Matthew.Fallshaw on 11 Jun 2012 at 10:10

GoogleCodeExporter commented 9 years ago

Original comment by Matthew.Fallshaw on 14 Jun 2012 at 2:24

Added labels: Estimate-2

GoogleCodeExporter commented 9 years ago

Original comment by Matthew.Fallshaw on 3 Jul 2012 at 9:26

Changed state: Authorised

GoogleCodeExporter commented 9 years ago

Deployed

Original comment by wjmo...@gmail.com on 3 Aug 2012 at 5:45

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

This has produced some additional minor bugs.  Now you can be displaying 
multiple instances of the same comment on the same page, which results in 
several HTML elements with the same id attribute - that results in undefined 
behavior.  For example, clicking the "vote up" button on one instance of a 
comment might change the color of a different instance's thumb.

Original comment by thethomb...@gmail.com on 3 Aug 2012 at 6:30

GoogleCodeExporter commented 9 years ago

Thanks for letting us know. Have forwarded to John to fix.

Original comment by wjmo...@gmail.com on 5 Aug 2012 at 11:06

Changed state: Started

GoogleCodeExporter commented 9 years ago

Merged and deployed voting fixes from John.

Original comment by wjmo...@gmail.com on 14 Aug 2012 at 12:38

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Things are still behaving oddly for me - often I can't upvote or downvote 
something the first time I try, even beyond /comments, and have to open a 
permalink or try 3 times, as far as I can tell.  In the best case, there's 
usually a delay between when I click and when the thumb changes color.  
Whatever just happened, I don't think it was an improvement.

Original comment by yudkow...@gmail.com on 15 Aug 2012 at 7:49

GoogleCodeExporter commented 9 years ago

Original comment by Matthew.Fallshaw on 15 Aug 2012 at 9:31

GoogleCodeExporter commented 9 years ago

Eliezer, we're having trouble reproducing your troubles. Can you try for a more 
formal bug report?

Original comment by Matthew.Fallshaw on 20 Aug 2012 at 7:22