search

belluzj / fantasque-sans

A font family with a great monospaced variant for programmers.
http://openfontlibrary.org/en/font/fantasque-sans-mono
SIL Open Font License 1.1
7.06k stars 155 forks source link

Update validate-generate script to support python3 #45

Closed vyp closed 9 years ago

vyp commented 9 years ago

Closes #43.

Sorry I screwed up #44 pull request by amending a commit message that I already pushed. Here is a new clean one which shouldn't cause problems. #44 might cause problems because it's asking to merge a commit that doesn't exist anymore (although I'm not 100% sure).

Here's the original text from #44:

I had a (relatively brief) look to find out how to detect which version of python one's fontforge would use, but couldn't find an answer. So does it just use the system python binary?

Because if so, this might work, but if not, this is probably not the solution.

Also note I have not looked at the rest of the script or anything, and this is just a very rudimentary patch I made in 2 seconds, so I do not know if this breaks anything. But running make does work for me now, as opposed to before.

belluzj commented 9 years ago

I did not merge this PR because as you suggest I'm afraid you're testing for the system python version whereas the script uses the one that is embedded in Fontforge. And anyway, adding the needed parentheses after print works in both python 2 and 3.

vyp commented 9 years ago

Yep no worries. And yes good point, I forgot python 2 also has a print function.