search

bemanproject / beman

Organization, documentation, etc. for the Beman Project
https://bemanproject.org
Apache License 2.0
30 stars 11 forks source link

Update library prefix to `beman_` #69

Closed wusatosi closed 1 day ago

wusatosi commented 1 week ago

In accordance to agreement in weekly sync:

Any beman.<short_name> Beman library name should be converted to beman_<short_name> for filling in the keys in YAML/configs inside the Compiler Explorer infrastructure. The display name from CE UI can be still set to beman.<short_name>, via libs.beman_.name = beman.<short_name>.

Packed a consistency fix LIBRARY.NAMES -> LIBRARY.NAME as it is inconsistent to REPOSITORY.NAME.

neatudarius commented 2 days ago

70

wusatosi commented 1 day ago

Thanks for replying to this PR, noted.

So I assume the all the libraries should still be named as beman_shortname?

Edit: oh crap I mis-typed, I meant beman.shortname

neatudarius commented 1 day ago

Thanks for replying to this PR, noted.

So I assume the all the libraries should still be named as beman_shortname?

Not sure what you are asking. We should not change anything to Beman Standard because nobody voted / proposed this at the sync.

Beman Standard says:

image

So beman.optional26 it's everywhere in our org. No update from this PR should be kept. AFAIK.

I will clarify the CE naming in #70 .

wusatosi commented 1 day ago

Alright, I was reading the meeting note and misunderstood, closing this.

neatudarius commented 1 day ago

Examples can be found here: https://github.com/compiler-explorer/infra/pull/1453/files

beman_iterator_interface and beman.iterator_interface are both used in the compiler explorer config (as key in config and value in config). @wusatosi , does this clarify the issue?

wusatosi commented 1 day ago

Examples can be found here: https://github.com/compiler-explorer/infra/pull/1453/files

beman_iterator_interface and beman.iterator_interface are both used in the compiler explorer config (as key in config and value in config). @wusatosi , does this clarify the issue?

Alright, yeah I understand now.

According to: https://github.com/bemanproject/inplace_vector/pull/14#discussion_r1843440554

execution26 might be non-comforming.

wusatosi commented 1 day ago

Thanks for replying to this PR, noted.

So I assume the all the libraries should still be named as beman_shortname?

Edit: oh crap I mis-typed, I meant beman.shortname

I miss typed. Should be beman.shortname