bemusic / bemuse

⬤▗▚▚▚ Web-based online rhythm action game. Based on HTML5 technologies, React, Redux and Pixi.js.
https://bemuse.ninja/
GNU Affero General Public License v3.0
1.12k stars 143 forks source link

Remove impure #814

Closed MikuroXina closed 1 year ago

MikuroXina commented 1 year ago

Separated from #790.

codecov-commenter commented 1 year ago

Codecov Report

Base: 95.54% // Head: 86.46% // Decreases project coverage by -9.07% :warning:

Coverage data is based on head (4a0461c) compared to base (9c46e3a). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #814 +/- ## ========================================== - Coverage 95.54% 86.46% -9.08% ========================================== Files 39 175 +136 Lines 673 5378 +4705 Branches 65 362 +297 ========================================== + Hits 643 4650 +4007 - Misses 15 678 +663 - Partials 15 50 +35 ``` | [Impacted Files](https://codecov.io/gh/bemusic/bemuse/pull/814?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | Coverage Δ | | |---|---|---| | [bemuse/src/utils/read-blob.js](https://codecov.io/gh/bemusic/bemuse/pull/814/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy91dGlscy9yZWFkLWJsb2IuanM=) | `100.00% <0.00%> (ø)` | | | [bemuse/src/game/input/touch-plugin.spec.js](https://codecov.io/gh/bemusic/bemuse/pull/814/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9nYW1lL2lucHV0L3RvdWNoLXBsdWdpbi5zcGVjLmpz) | `100.00% <0.00%> (ø)` | | | [bemuse/src/test/karma.js](https://codecov.io/gh/bemusic/bemuse/pull/814/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy90ZXN0L2thcm1hLmpz) | `100.00% <0.00%> (ø)` | | | [bemuse/src/custom-folder/index.spec.ts](https://codecov.io/gh/bemusic/bemuse/pull/814/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9jdXN0b20tZm9sZGVyL2luZGV4LnNwZWMudHM=) | `93.54% <0.00%> (ø)` | | | [bemuse/src/music-collection/sortSongs.js](https://codecov.io/gh/bemusic/bemuse/pull/814/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9tdXNpYy1jb2xsZWN0aW9uL3NvcnRTb25ncy5qcw==) | `71.42% <0.00%> (ø)` | | | [bemuse/src/sampling-master/index.spec.js](https://codecov.io/gh/bemusic/bemuse/pull/814/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9zYW1wbGluZy1tYXN0ZXIvaW5kZXguc3BlYy5qcw==) | `96.12% <0.00%> (ø)` | | | [bemuse/src/custom-song-loader/index.spec.js](https://codecov.io/gh/bemusic/bemuse/pull/814/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9jdXN0b20tc29uZy1sb2FkZXIvaW5kZXguc3BlYy5qcw==) | `100.00% <0.00%> (ø)` | | | [bemuse/src/resources/bemuse-package.spec.js](https://codecov.io/gh/bemusic/bemuse/pull/814/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9yZXNvdXJjZXMvYmVtdXNlLXBhY2thZ2Uuc3BlYy5qcw==) | `100.00% <0.00%> (ø)` | | | [bemuse/src/test/loadSpecs.js](https://codecov.io/gh/bemusic/bemuse/pull/814/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy90ZXN0L2xvYWRTcGVjcy5qcw==) | `100.00% <0.00%> (ø)` | | | [bemuse/src/game/display/note-area.js](https://codecov.io/gh/bemusic/bemuse/pull/814/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic#diff-YmVtdXNlL3NyYy9nYW1lL2Rpc3BsYXkvbm90ZS1hcmVhLmpz) | `100.00% <0.00%> (ø)` | | | ... and [126 more](https://codecov.io/gh/bemusic/bemuse/pull/814/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bemusic)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication