benariss / node-red-contrib-salesforce-bp3

A set of Node-RED nodes to interact with Salesforce and Force.com
MIT License
0 stars 0 forks source link

Merge back to node-red-contrib-salesforce #3

Open Stwissel opened 6 years ago

Stwissel commented 6 years ago

Hi there,

I took over from Jeff to look after the package (see https://www.npmjs.com/package/node-red-contrib-salesforce ). I already, short of implementing credentials via the msg.sf object, added your changes. I took a slight different approach (inspired by the way Heroku, Bluemix etc. handle this) and read credentials from the environment - but I don't see why both approaches can't co-exist.

Let's join forces. Suggest a Google Hangout

Stwissel commented 6 years ago

I backported your msg.sf evaluation to the main module. One difference: I use a flag in the config if it should check for msg.sf What I wonder: should the msg.sf values supercede the configuration values in all cases, not just when missing. I updated to the latest dependencies. Have a look if it works for you. https://github.com/Stwissel/node-red-contrib-salesforce

Suggestions and pull requests are welcome