[BUG] opensearch.xml does not work properly for me

benbusby / whoogle-search

A self-hosted, ad-free, privacy-respecting metasearch engine

https://pypi.org/project/whoogle-search/

MIT License

9.62k stars 949 forks source link

[BUG] opensearch.xml does not work properly for me #632

Open napca opened 2 years ago

napca commented 2 years ago

https://github.com/benbusby/whoogle-search/commit/933ce7e0685148033aa92ed4ed03efb0c062a201#diff-20957d0195632ceb40d9c0eac90d89bf666fdbae387d2c5c1eeee16f9f88c4d4 reverting this to old state makes the search box work properly on my firefox. can you revert this? EDIT 1: I had to merge both of these, now it looks like these: (had to take a screenshot because github does not like the formatting of it.

benbusby commented 2 years ago

The issue with adding ?q={searchTerms} is that it exposes the search terms in network logs for users who prefer to send the their query as a POST request. That also shouldn't be required, since the request method will automatically format the URL with that addition if the GET Requests Only option is enabled.

I'm curious why the default opensearch.xml wasn't working for you at all though, as I use Firefox and the search box works with my instance. Can you send me the version of Firefox you're running? And any Whoogle config options you have enabled?

sutidor commented 2 years ago

It is the same for me, in FF Linux it works, in Windows (11) it's broken. Docker, latest, behind nginx, no extra config. I tried to add WHOOGLE_CONFIG_URL as well. I keep redirecting on /home even instead of /search. When I just input url it is / location. Edit: I noticed that when I put WHOOGLE_CONFIG_URL=https://some.url it will translate into http://some.url in config and openxml. But even changing it manually to https:// doesn't solve. To top it off: Win10, FF 97.0.1 is working. If anybody can clear the confusion, I'd be more than happy.