search

bencheeorg / benchee

Easy and extensible benchmarking in Elixir providing you with lots of statistics!
MIT License
1.41k stars 66 forks source link

Add Solaris Support to Benchee.System #421

Closed brianewell closed 9 months ago

brianewell commented 9 months ago

It would be nice for Benchee to recognize when it's running on Solaris/Illumos platforms instead of just assuming that it's on Linux, ie:

cat: /proc/meminfo: No such file or directory
Something went wrong trying to get system information:

cat: /proc/cpuinfo: No such file or directory
Something went wrong trying to get system information:

Operating System: Linux
CPU Information: N/A
Number of Available Cores: 48
Available memory: N/A
Elixir 1.15.7
Erlang 26.1.2

Would become:

Operating System: Solaris
CPU Information: Intel(r) Xeon(r) CPU E5-2678 v3 @ 2.50GHz
Number of Available Cores: 48
Available memory: 8 GB
Elixir 1.15.7
Erlang 26.1.2
JIT enabled: true
PragTob commented 9 months ago

:wave:

Hi there, thanks for the report! Help is welcome with this - I don't have a solaris system or idea where to get that information in a Solaris information or how to recognize it's Solaris and not Linux.

If anyone could provide that information or even implement the feature I'd be very happy :grin:

Otherwise, this will probably wait for a while for me to groom the backlog at some point and be like "ok let's get a VM and dive into this" :grin:

brianewell commented 9 months ago

This is my first PR for a public elixir library, please let me know if I missed anything: https://github.com/bencheeorg/benchee/pull/422

PragTob commented 9 months ago

Fixed by #422 !