benedekrozemberczki / karateclub

Karate Club: An API Oriented Open-source Python Framework for Unsupervised Learning on Graphs (CIKM 2020)
https://karateclub.readthedocs.io
GNU General Public License v3.0
2.14k stars 244 forks source link

Relax dependency requirements #137

Closed WhatTheFuzz closed 1 year ago

WhatTheFuzz commented 1 year ago

Relate #133

codecov-commenter commented 1 year ago

Codecov Report

Merging #137 (2fc703e) into master (de4cdb4) will increase coverage by 0.01%. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   97.39%   97.41%   +0.01%     
==========================================
  Files          63       63              
  Lines        2692     2703      +11     
==========================================
+ Hits         2622     2633      +11     
  Misses         70       70              
Impacted Files Coverage Δ
karateclub/graph_embedding/gl2vec.py 100.00% <ø> (ø)
karateclub/graph_embedding/graph2vec.py 100.00% <ø> (ø)
karateclub/node_embedding/attributed/ae.py 100.00% <ø> (ø)
karateclub/node_embedding/attributed/asne.py 100.00% <ø> (ø)
karateclub/node_embedding/attributed/musae.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

benedekrozemberczki commented 1 year ago

Looks good, do you want to conver it for a full PR?

WhatTheFuzz commented 1 year ago

Tested out numpy as well. Since networkx 3 < seems to make breaking changes, I didn't touch that yet.

rjurney commented 1 year ago

@WhatTheFuzz I am looking at bumping it to networkx 3.1 now.

WhatTheFuzz commented 1 year ago

@WhatTheFuzz I am looking at bumping it to networkx 3.1 now.

Yeah, it would be great to have assistance bumping it to >= 3.1!