benetech / Imageshare

MIT License
0 stars 0 forks source link

Focus Outline Improvements #269

Closed sinabahram closed 3 years ago

sinabahram commented 3 years ago

Tagging in @jkva for this.

Thanks go to Lauren for these two sugestions.

  1. For \<button> and \<input>: add an offset to the current focus outline and effect a change in the background color of the button to increase visibility. It may be useful to add offset in other areas as well to ensure the outline doesn't obstruct whatever it's highlighting.
  2. For \<li> with role = option: add a bottom border to current background change on focus so indication is not by color alone.
jkva commented 3 years ago

Done via bdf272cc064edfe8975d09923aeb513064e2c0de and f84a9d786bfae2a9e84a4c990171218337281563