benfred / implicit

Fast Python Collaborative Filtering for Implicit Feedback Datasets
https://benfred.github.io/implicit/
MIT License
3.57k stars 612 forks source link

Fix als test_rank_items on GPU #479

Closed benfred closed 3 years ago

benfred commented 3 years ago

We had an issue where we were filtering out scores < 0 in the gpu code, which caused a bug in the gpu test_rank_items code for ALS. Fix, and ensure that the unittest is actually working on the GPU