benfry / processing4

Processing 4.x releases for Java 17
https://processing.org
Other
1.35k stars 237 forks source link

Refactor description of arrays in debugger. #713

Closed sampottinger closed 1 year ago

sampottinger commented 1 year ago

Closes #606, builds on #692 from @WillRabalais04.

sampottinger commented 1 year ago

[edited slightly]

Hey @WillRabalais04! Can you do a code review on this and see how my additions feel? It’s built from your #692 (thank you! 👍✨) with a few additions:

Re, regex: We can reverse out on this. Curious to get your opinion. Given the age and multiple strata from multiple generations of contributors (😅) I've found that, for Processing, sometimes consolidating to a documented / tested regex is sometimes a bit easier to maintain when working on some of the string manipulation if the regex isn’t too involved.

sampottinger commented 1 year ago

CC @SableRaf - Is it possible to add GSoC folks to the repo if they join our communal pledge not to push direct to main? @WillRabalais04 - how would you feel about that power / responsibility?

SableRaf commented 1 year ago

CC @SableRaf - Is it possible to add GSoC folks to the repo if they join our communal pledge not to push direct to main?

We could also consider adding branch protection to the repository: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches

sampottinger commented 1 year ago

Yeah I’m into that. I think we haven’t so far because the list of contributors with upstream access has been small. Requiring pr (with an exceptions list including Ben) to get to main would be ideal either way though.

sampottinger commented 1 year ago

Superseded by #729