bengtmartensson / IrpTransmogrifier

Parser for IRP notation protocols, with rendering, code generation, and decoding.
http://www.harctoolbox.org/
GNU General Public License v3.0
26 stars 5 forks source link

Many protocols have no repeat marker in IrpProtocols.xml #230

Closed seanyoung closed 1 year ago

seanyoung commented 1 year ago

For example, Sony8 is defined as {40k,600}<1,-1|2,-1>(4,-1,F:8,^45m)[F:0..255], which means there is no repeat, there is only a key down event. This is true for many protocols, e.g. 48-NEC as well.

I am not sure this is correct. Surely you can press and hold buttons on these remotes.

Would the * form make more sense here?

$ ./irptransmogrifier.sh --irp '{40k,600}<1,-1|2,-1>(4,-1,F:8,^45m)[F:0..255]' render -p -n F=255
0000 0068 0009 0000 0060 0018 0030 0018 0030 0018 0030 0018 0030 0018 0030 0018 0030 0018 0030 0018 0030 0468
$ ./irptransmogrifier.sh --irp '{40k,600}<1,-1|2,-1>(4,-1,F:8,^45m)*[F:0..255]' render -p -n F=255
0000 0068 0000 0009 0060 0018 0030 0018 0030 0018 0030 0018 0030 0018 0030 0018 0030 0018 0030 0018 0030 0468

I'm happy to create a PR which fixes these protocols.

bengtmartensson commented 1 year ago

Hi Sean,

thank you for the suggestion. The 48-NEC (as well as all protocols ending with "NEC") is (are) correct and meaningful; it (they) represent(s) an incomplete learn. Note that decode-only is set to true. It is (they are) not first-class protocols. (This is explained in the documentation.) Sony8: I do not recall right now where it is used, however, I suspect that it can be argued that it is not a really professional protocol either.

But I take the view that I have just "inherited" the protocols from the JP1 community/forum, in particular DecodeIR (Quite antique, but is linked to incredibly often, in this year 2023.) So I would suggest that you create one or more discussions there, before we change the definitions.

I will be unavailable for the next few days, sorry.

seanyoung commented 1 year ago

As always, thank you for your insight.

seanyoung commented 1 year ago

As the forum is the appropriate place to discuss this, closing this issue. Thanks for your help.

seanyoung commented 1 year ago

I've posted: http://www.hifi-remote.com/forums/viewtopic.php?t=103217