JFileChooserFixture textbox access

[GoogleCodeExporter]

Very minor suggestion:

The textbox on the JFileChooserFixture is accessed through
"fileNameTextBox".  Textboxes in other fixtures are accessed through just
"textBox".  Should this be changed for consistency?

Version 1.0 alpha 3 - Windows XP SP2

Original issue reported on code.google.com by dbguse...@gmail.com on 15 Jul 2008 at 1:42

[GoogleCodeExporter]

I agree with you about naming consistency. My only concern is that having 
only "textBox" may confuse users. In this case (JFileChooserFixture), the name 
is 
pretty intuitive. On the other hand, there is only one text box in a 
JFileChooser.

Any thoughs?

Thanks!
-Yvonne

Original comment by wanghy1...@gmail.com on 15 Jul 2008 at 3:05

• Changed title: [fest-swing] JFileChooserFixture textbox access
• Changed state: Accepted
• Added labels: Milestone-Release1.0, OpSys-All, Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

Hi,

I have to agree with Yvonne, textBox would clash with ContainerFixture#textBox.
fileNameTextBox reinforces the fact that JFileChooser isn't really a container.
Also, JFileChooser might contain a custom component which might be a text box 
or it
might have a text box descendant.

Regards,
Csabi

Original comment by csaba.ju...@gmail.com on 17 Jul 2008 at 7:50

[GoogleCodeExporter]

Thanks Csabi. I think it is safe to mark this issue as 'invalid'.

Original comment by wanghy1...@gmail.com on 19 Jul 2008 at 3:49

• Changed state: Invalid

[GoogleCodeExporter]

Set the module as a label, instead of being part of the title.

Original comment by Alex.Rui...@gmail.com on 1 Dec 2008 at 2:08

• Changed title: JFileChooserFixture textbox access
• Added labels: Module-fest-swing