benjaminch / pricers

This library supports RTB development for Open RTB common price encryption in Golang.
GNU General Public License v3.0
8 stars 4 forks source link

Remove debug #17

Open stokito opened 1 year ago

stokito commented 1 year ago

The logging is almost useless for users but a developer can debug in IDE. The raw keys bytes are not saying anything. We have errors to return a message to a caller. In the same time the code needs to be compiled and it makes the program slower because it resides in CPU cache. I going to send another PR with a performance improvement and for it I anyway need to broke the logging in some places.

I benchmarked and even when the logging is disabled it still makes code slower because it takes some place in CPU instructions cache.

The PR has some minor refactoring of tests.