Closed synicasm closed 3 years ago
I noticed this today so just posting to confirm it. JSON Example:
{
[...]
"name": "Araku Tiki",
"typeLine": "Coral Amulet",
"identified": true,
"ilvl": 9,
"implicitMods": [
"Regenerate 2.2 Life per second"
],
"explicitMods": [
"+100 to Evasion Rating while on Low Life",
"+32 to maximum Life",
"+27% to Fire Resistance",
"Regenerate 1% of Life per second while on Low Life"
],
[...]
}
I don't know scala so having trouble figuring out where in the code even handles this. I think this is the current code. It's using the parser:
P.simple1("", s"Life Regenerated per second")(_.other.lifeRegeneratedPerSecond)```
This compiles to the expression: `^([.+-\\d]+)%* Life Regenerated per second$`
I think the fix needed is to replace the above with: ```scala
P.simple1("Regenerate", s"Life per second")(_.other.lifeRegeneratedPerSecond)
For the original code just adds together all life regeneration mods but having them separate seems like a good idea. Something like:
addMod("% Life regeneration",
"Percent Life Regeneration Rate Per Second",
P.simple1("Regenerate", s"of Life per second.*")(_.other.lifePercentRegeneratedPerSecond))
Then lifePercentRegeneratedPerSecond
would need to be added to the other files.
I think I got it right. @AnnanFay you are on the right track. As far as I was able to deduce, adding parsing for affix is done in 3 files:
Life Regen can be represented 2 ways
Regenerate % of Life per Second Regenerate X life per second.
Neither appear to be showing up under this category.