Overhaul language selection - Githubissues

benkeen / generatedata

A powerful, feature-rich, random test data generator.

https://generatedata.com

2.21k stars 610 forks source link

Overhaul language selection #711

Closed benkeen closed 2 years ago

benkeen commented 2 years ago

The i18n functionality isn't great. It's too hidden, hard to locate & you can't share it.

Changes:

move the icon from the footer to the header, and drop the icon. Instead put "EN" or "FR" or what have you, making it clear it's clickable.
drop the tooltip and put it into a modal, revising the layout to make better use of space. Icons for countries are nice... but since one language supports multiple countries, not sure that's a good idea.
update the routing to support the language as part of the URL. This'll allow bookmarking.

benkeen commented 2 years ago

Pretty much there now. Remaining:

~finish URL routing.~
should look & function on small screens.
header links should be selected.
should work with extensions (website)
general QA