search

bennymeg / nx-electron

Electron schematics for nrwl nx platform
Apache License 2.0
333 stars 85 forks source link

Update generate-package-json.ts #141

Closed markscarna closed 2 years ago

markscarna commented 2 years ago

update deprecated package @nrwl/workspace to @nrwl/devkit

markscarna commented 2 years ago

You can move writeJsonFile, and readJsonFile to line 1. You're importing twice from @nrwl/devkit when it can be once. :)

Good point! I consolidated the imports.

lailo commented 2 years ago

I tried this code with nx v13.7.3 but got the following errors:

Error: Unable to resolve nx-electron:execute.
The "nx-electron" package does not support Nx executors.
    at Workspaces.readExecutor (/Users/project/node_modules/@nrwl/tao/src/shared/workspace.js:92:19)
    at getExecutorForTask (/Users/project/node_modules/@nrwl/workspace/src/tasks-runner/utils.js:135:22)
    at getCustomHasher (/Users/project/node_modules/@nrwl/workspace/src/tasks-runner/utils.js:140:25)
    at TasksSchedule.<anonymous> (/Users/project/node_modules/@nrwl/workspace/src/tasks-runner/tasks-schedule.js:114:62)
    at Generator.next (<anonymous>)
    at /Users/project/node_modules/tslib/tslib.js:117:75
    at new Promise (<anonymous>)
    at __awaiter (/Users/project/node_modules/tslib/tslib.js:113:16)
    at TasksSchedule.hashTask (/Users/project/node_modules/@nrwl/workspace/src/tasks-runner/tasks-schedule.js:113:38)
    at TasksSchedule.<anonymous> (/Users/project/node_modules/@nrwl/workspace/src/tasks-runner/tasks-schedule.js:58:24)
Unexpected error:
Error: Unable to load hasher for task "electron-app:serve"
    at getCustomHasher (/Users/project/node_modules/@nrwl/workspace/src/tasks-runner/utils.js:145:15)
    at TasksSchedule.<anonymous> (/Users/project/node_modules/@nrwl/workspace/src/tasks-runner/tasks-schedule.js:114:62)
    at Generator.next (<anonymous>)
    at /Users/project/node_modules/tslib/tslib.js:117:75
    at new Promise (<anonymous>)
    at __awaiter (/Users/project/node_modules/tslib/tslib.js:113:16)
    at TasksSchedule.hashTask (/Users/project/node_modules/@nrwl/workspace/src/tasks-runner/tasks-schedule.js:113:38)
    at TasksSchedule.<anonymous> (/Users/project/node_modules/@nrwl/workspace/src/tasks-runner/tasks-schedule.js:58:24)
    at Generator.next (<anonymous>)
    at /Users/project/node_modules/tslib/tslib.js:117:75
The terminal process "/bin/zsh '-c', 'npx nx serve electron-app'" terminated with exit code: 1.
bennymeg commented 2 years ago

That is one of the changes needed to be done for v13. I have opened a new branch for that matter (it might not be compatible with v12).