benoitc / couchbeam

Apache CouchDB client in Erlang
Other
242 stars 113 forks source link

lhttpc is not in the dependency list #34

Closed samuelrivas closed 14 years ago

samuelrivas commented 14 years ago

It's not very serious, but makes my automated way of starting apps fail. The fix is rather simple, just apply this patch.

diff --git a/ebin/couchbeam.app b/ebin/couchbeam.app
index 9a712e3..180a696 100644
--- a/ebin/couchbeam.app
+++ b/ebin/couchbeam.app
@@ -16,6 +16,6 @@
                         couchbeam_util,
                         couchbeam_sup]},
               {registered,[couchbeam_sup]},
-              {applications,[kernel, stdlib]},
+              {applications,[kernel, stdlib, lhttpc]},
                          {env, []},
                          {mod, {couchbeam, []}}]}.
benoitc commented 14 years ago

mmm not sure to understand. couchbeam:start normally start lhttpc. If I do this then it will need to start crypto and ssl like this too?

samuelrivas commented 14 years ago

If you already start all the dependencies manually (e.g. what couchbeam:start does) this change doesn't affect you. The dependencies in the .app file just make sure that application:start(couchbeam) fail unless lhttpc is started.

Since lhttpc .app file already depend on crypto and ssl, you don't need to include those in your dependency list, application:start(lhttpc) will fail if they are not started, and application:start(couchbeam) will fail if lhttpc is not started.

The dependencies in the .app file are important if you use OTP standard release handling tools. They use them to create release tarballs or bootfiles with correct booting sequences.

Hope it helps

benoitc commented 14 years ago

Fixed in head. Thanks for the patch and explanation :)