Implement Ruff with config an pre-commit hook - Githubissues

bensteUEM / ChurchToolsAPI

Collection of Python files to use the API for ChurchTools

6 stars 3 forks source link

Implement Ruff with config an pre-commit hook #102

Open bensteUEM opened 1 month ago

bensteUEM commented 1 month ago

[x] implement ruff
[x] add pre-commit hook
[x] create custom config
[ ] cleanup legacy code

bensteUEM commented 3 weeks ago

[ ] FA100 https://docs.astral.sh/ruff/rules/future-rewritable-type-annotation/#why-is-this-bad

bensteUEM commented 3 weeks ago

[ ] Type Annotations "ANN001","ANN002","ANN003","ANN201"

bensteUEM commented 3 weeks ago

[ ] "C901", #complexity

bensteUEM commented 3 weeks ago

[ ] ARG002 Unused method argument as followup of incomplete implementation of #110

bensteUEM commented 3 weeks ago

[ ] FA100 Add from __future__ import annotations to simplify typing.Optional => or use python 3.10 or newer

bensteUEM commented 3 weeks ago

[ ] "D100","D101","D102","D104","D107","D205","D415", #Docstrings

bensteUEM commented 3 weeks ago

[ ] "E501", #line too long

bensteUEM commented 3 weeks ago

[ ] "DTZ001","DTZ005","DTZ007","DTZ002", #datetime timezone

bensteUEM commented 3 weeks ago

[ ] Naming changes "N802", #function lowercase -> breaking change "N803", #argument lowercase -> breaking change "N806", #variable name lowercase -> breaking change

bensteUEM commented 3 weeks ago

[x] "PTH110","PTH107","PTH123","PTH118","PTH112","PTH103", #Path changes

bensteUEM commented 3 weeks ago

shadowed param names (annotated with noqa in Code)

[ ] A002 -> breaking change
[ ] A001 -> breaking change