search

bentasker / HLS-Stream-Creator

Simple Bash Script to take a media file, segment it and create an M3U8 playlist for serving using HLS
BSD 3-Clause "New" or "Revised" License
273 stars 101 forks source link

Added AES-128 encryption to the generated files #7

Closed kavuri closed 9 years ago

kavuri commented 9 years ago

Added switch -e to encrypt the segments. Followed the instructions from here: http://www.barryodonovan.com/2010/08/30/http-streaming-with-encryption-under-linux-2

Signed-off-by: Sateesh Kavuri sateesh.kavuri@gmail.com

bentasker commented 9 years ago

Hi,

Thanks, could you make one minor change and then I'll merge:

As the change won't work with Linear video (the stream would need to end before the encryption process could start) could you amend the encrypt check to also check whether it's a live stream?

I.e.

    if [ "$ENCRYPT" == "1" ]
    then

Becomes

    if [ "$ENCRYPT" == "1" ] && [ "$LIVE_STREAM" == "0" ]
    then

Other than that, looks good thanks.

kavuri commented 9 years ago

Added condition for live stream check and updated to the same pull request

Thanks, Sateesh

On Fri, Jul 3, 2015 at 9:23 PM, Ben Tasker notifications@github.com wrote:

Hi,

Thanks, could you make one minor change and then I'll merge:

As the change won't work with Linear video (the stream would need to end before the encryption process could start) could you amend the encrypt check to also check whether it's a live stream?

I.e. if [ "$ENCRYPT" == "1" ] then

Becomes

if [ "$ENCRYPT" == "1" ] && [ "$LIVE_STREAM" == "0" ] then

Other than that, looks good thanks.

— Reply to this email directly or view it on GitHub https://github.com/bentasker/HLS-Stream-Creator/pull/7#issuecomment-118380025 .

bentasker commented 9 years ago

Awesome thanks, looks good to me so merging