[GAT-BEI003-34] Application crashes when it is launched

gatgithub commented 8 years ago

Issue No: 34 Device: iphone 6s iOS 9.2

Affected Component(s)

Log in / Sign up

Bug Description

ACTUAL RESULTS:- It allowed to crash the application when it was launched

EXPECTED RESULTS:- It should not allow to crash the application

OTHER NOTES / ERROR MESSAGES:- Log Crash: http://bugs8.gatserver.com/uploads/3020ba467758698aa17af3185369d1b9.txt Video : http://bugs8.gatserver.com/uploads/7af1a0d8c2254344df3fd23ed5b8ad09.mp4

Reproduction Steps

Tap on Application icon
Application keeps on loading
application crashes

vcardillo commented 8 years ago

@JosephLauSF: Thoughts?

josephlausf commented 8 years ago

This should be a timed out network request that wasn't handled properly and allowed the app to proceed to the build screen, which immediately checks for saved location and if not available, it loads the map screen. When loading up the map screen, the app first tries to retrieve the service area polygon in order to display the map from above the service area, but since the initial network request had failed, a null value was set and was being used, which crashed the app. This only happens when asking for user location for the first time AND when the internet connection is bad. By the way, all of this happens really fast, so it's not visible in the UI.

Fixed this by disallowing the app to navigate to the build screen if request times out on launch.

josephlausf commented 8 years ago

http://recordit.co/0SyvwBQzjz

vcardillo commented 8 years ago

Cool, nice.

On Tue, Feb 2, 2016 at 4:59 PM, Joseph Lau notifications@github.com wrote:

http://recordit.co/0SyvwBQzjz

— Reply to this email directly or view it on GitHub https://github.com/bentocorp/ios/issues/488#issuecomment-178929507.

gatgithub commented 8 years ago

Verified fixed - 09.02.2016 - the app is stable and works properly when launched

bentocorp / ios