search

benvinegar / counterscale

Scalable web analytics you run yourself on Cloudflare
https://counterscale.dev
MIT License
1.52k stars 66 forks source link

Enable no explicit any #40

Closed calirvine closed 9 months ago

calirvine commented 9 months ago

Removed last remaining explicit any.

I would recommend dropping prop-types as a dependency and using typescript for the components as well, as the api is pretty verbose and not as expressive. On top of that, PropTypes perform a runtime typecheck, but ideally runtime type checking should be happening at the API boundaries, allowing us to trust typescript throughout the rest of the application.

Because PropTypes performs runtime type checking, this PR should not be treated as type level only changes.

Closes #13

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1d743a1) 72.88% compared to head (e66f1be) 72.96%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #40 +/- ## ========================================== + Coverage 72.88% 72.96% +0.08% ========================================== Files 18 18 Lines 1973 1979 +6 Branches 119 119 ========================================== + Hits 1438 1444 +6 Misses 529 529 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benvinegar commented 9 months ago

Awesome! (I'll try to keep the prop-types stuff in mind – but I'm probably more focused on adding table-stakes missing features vs. achieving full static checking enlightenment). I do have production visibility now with Sentry (#32).