search

benvinegar / counterscale

Scalable web analytics you run yourself on Cloudflare
https://counterscale.dev
MIT License
1.52k stars 66 forks source link

Table card row fill rendering incorrectly on Safari #44

Closed benvinegar closed 9 months ago

benvinegar commented 9 months ago
image
benvinegar commented 9 months ago

This is apparently an old WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=34392

anurag-roy commented 9 months ago

@benvinegar yep that's what I found too - the background is being applied to each td element rather than their containing tr.

Changing the display on the td to block or flex seems to solve that, but is causing other issues like the row not occupying 100% of the width.

I'm still giving it a shot and seeing if anything works!

benvinegar commented 9 months ago

I was thinking of just abandoning trying to apply the gardient to the row and instead apply it to the first td alone, which should work in all browsers. It just will mean the bars won't look as "full", which is probably okay.

anurag-roy commented 9 months ago

Yes that works too, if not better. I can give it a shot, if that's fine.

benvinegar commented 9 months ago

Closed by #46