search

benyamindsmith / starBliss

Create beautiful, print quality maps of the night sky in R
43 stars 2 forks source link

cant add time to datetime #13

Closed ilyinss closed 8 months ago

ilyinss commented 1 year ago

Hello, its me again!

in method you wrote: dt_tm <- lubridate::as_datetime(paste(dt, " 22:00:00"), tz = "UTC") then, user cant add a time. You are hardcoding it (( can you edit it like this: if user not add time - you paste 22:00 if user add time - you calculate strar map with his time

Sergey

benyamindsmith commented 1 year ago

This package aims to replicate the product produced by MapsForMoments. @dieghernan was kind enough to do alot of work for figuring out how to replicate the maps as far as datetime is concerned and learned that this is what MapsForMoments does.

For more reading see Diego's blog in #7 and #10

ilyinss commented 1 year ago

yes, i'm understand it. but MapsForMoments - its commercial service. i think your library can be more strong than MFM service because it's opensource

benyamindsmith commented 8 months ago

@ilyinss Going to close this issue.

I hope you are enjoying the package still!