bergerhealer / MyWorlds

Cross-world teleportations and world managing commands
MIT License
51 stars 6 forks source link

Autocomplete commands #56

Closed Rod-bor closed 1 year ago

Rod-bor commented 1 year ago

As you know, Minecraft has autocomplete commands, a hint. I was going to remove some of these autocomplete commands for players without op on my server. When I got to the commands of THIS plugin, not only are they not hidden by default for players without op, but moreover they cannot be hidden, because the hints contain a SPACE! I very much ask you to remove this space/ add the ability to remove, or at least remove this function for players without op. This is generally the first plugin in which I encounter such stuff.

If it's not clear which autocomplete commands I'm talking about, here's a screenshot: image I hope this will be fixed soon.

bergerkiller commented 1 year ago

Its not exactly a priority to make this better. In my other plugins Ive migrated away from writing my own suggestions system and use the Cloud command framework instead. Myworlds is an odd one where its something I hacked together on top of an existing thing I had.

I can add a perm that disables all myworlds command suggestions though. But I dont want to 'fix' it, as I want to eventually replace the whole thing instead.

Rod-bor commented 1 year ago

Thanks for the quick response! I would really appreciate it if you added perm to turn off myworlds command suggestions.

bergerkiller commented 1 year ago

Does this help? https://ci.mg-dev.eu/job/MyWorlds/253/

Revoke the 'myworlds.command.suggestions' permission to hide autocompletions

Rod-bor commented 1 year ago

I tried adding myworlds.command.suggestions perm with false and with true, but nothing changed

bergerkiller commented 1 year ago

It should at least get rid of all the /myworlds [subcommand] suggestions right? Would be weird if it didnt. Its possible the "myworlds" command isnt hidden as thats controlled by the bukkit api

Rod-bor commented 1 year ago

I removed the op and set myworlds.command.suggestions to off and the /myworlds [subcommand] commands were not removed either

изображение

By the way, I found a way to remove suggestions from the command, I just used whitelist in the plugin to remove suggestions. If you want, you can finish this plugin feature for other users, I don't need it so much, thanks anyway.

bergerkiller commented 1 year ago

So youve found another way to get it hidden and I can close this? As I said before, better to just nuke the old system and replace it with cloud

Rod-bor commented 1 year ago

Yeah, of course