bergerhealer / MyWorlds

Cross-world teleportations and world managing commands
MIT License
51 stars 6 forks source link

Add CustomNPCs to loadbefore #64

Closed Foxikle closed 6 months ago

Foxikle commented 6 months ago

This pr loads the plugin before my plugin, CustomNPCs, which prevents issues with NPC initialization. This seems like it is working around the solution, when the plugin should load on startup, not post world. This can be achieved by putting load: STARTUP in the plugin.yml. This would probably take some testing with other dependencies, to ensure seamless integration.

bergerkiller commented 6 months ago

I believe load: STARTUP caused other problems, either related to the default worlds not having been initialized yet, or stuff related to load order because it yanks BKCommonLib to load before all this, too. Your fix looks alright. Typically what i find is people adding a softdepends of My_Worlds along with Multiverse but this works too.