search

berkeley-dsep-infra / hubploy

Toolkit to deploy many z2jh based JupyterHubs
BSD 3-Clause "New" or "Revised" License
17 stars 15 forks source link

AWS Terminology Updates #88

Closed salvis2 closed 4 years ago

salvis2 commented 4 years ago

Updates the terminology used for AWS deployment specifications. Closes #41 .

Should be backwards compatible. Copying my comment from the issue this will close:

I'll update the function signatures, docs, and hubploy-template, but I think it'll be automatically backwards compatible! Since the functions take in their parameters like this:

          elif provider == 'aws':
              yield from registry_auth_aws(
                  deployment, **registry['aws']
              )

I don't think the names of the entries in hubploy.yaml matter, but the order does.

Will update and notify about hubploy-template before merging.

yuvipanda commented 4 years ago

Thanks for working on this, @salvis2!

I'm not entirely sure we need to be backwards compatible in hubploy.yaml, but good to explicitly make that call.

yuvipanda commented 4 years ago

@salvis2 I actually just realized we already do a lot of backwards compatibility munging here: https://github.com/yuvipanda/hubploy/blob/master/hubploy/config.py#L183.

Can you add a few lines to make this happen too? I'm sorry I just realized this.

Thanks a lot for working on this!

salvis2 commented 4 years ago

@yuvipanda okay, did some hard-coding of backwards compatibility for those keys. I tested it on my own setup and it worked with the new AWS-specific terminologies and the old ones that we are replacing. I also updated a couple print messages related to image building, if that's fine with you.

salvis2 commented 4 years ago

Terminology is updated in hubploy-template here: https://github.com/yuvipanda/hubploy-template/pull/8

Should be ready to merge now.