berkus / muddle

Automatically exported from code.google.com/p/muddle
0 stars 0 forks source link

Revision numbers cannot be single digits #249

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
muddle stamp release xx 1

 gives an error:

Release version "1" is not allowed (it must start with 'A'-'Z', 'a'-'z' or 
'0'-'9', and may only continue with 'A'-'Z', 'a'-'z', '0'-'9', '_' '-' or '.')

 And probably shouldn't .. 

Original issue reported on code.google.com by rrw10...@gmail.com on 24 Feb 2013 at 5:54

GoogleCodeExporter commented 9 years ago
Fixed in a583b030844d66791058ca5a99cdaca4863c3f61

Clearly this should be allowed.

In fact, the error was that the regular expression being used for both name and 
version required two characters as minimum, instead of 1 (i.e., it used '+' 
instead of '*' for its second part). Whilst I'm not sure how useful a single 
character *name* is, I also can't see why it should be forbidded, and single 
character version "numbers" ([A-Za-z0-9]) are clearly sensible.

Original comment by t...@kynesim.co.uk on 25 Feb 2013 at 10:46