search

berkus / rietveld

Code review tool from Guido for Django
code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

No way to delete old reviews #468

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Create a review with account1
2. Go to apps panel and delete account1
3. Enter code review tool -- nobody but account1 can delete the review, it is 
now there forever.

What is the expected output? What do you see instead?
If the user that created the review no longer exists, admin should be able to 
delete.... or admin user should be able to delete as well as the owner. Even if 
you transferred ownership when we transfer docs in the google apps panel that 
would resolve this issue... 

What browser are you using?  What version? On what operating system?
Safari 7, OS X 10.9.0

At what URL are you accessing Rietveld?  (e.g. codereview.appspot.com)
Please note if you are using the Google Apps Labs version (e.g.
codereview.<yourdomain>).

codereview.elephantheadsoft.com

*** If you are a Google employee please say so or mail rietveld-admins@
directly. ***

Please provide any additional information below.

Original issue reported on code.google.com by anagr...@elephantheadsoft.com on 6 Nov 2013 at 5:04

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
I am not sure if this intentional, but there is an easy way for anyone to 
remove obsolete code reviews from the "Incoming Reviews" section.

Starting with the My Issues view, click on the unwanted review, then click on 
the Publish+Mail Comments link. Delete your name/email address from the 
Reviewers field, and click the Publish all my drafts button.

The unwanted review will disappear from the Incoming Reviews section and you 
will get an email update.  Note this does not work if you go into the diffs 
view before clicking on the Publish+Mail Comments button.

Original comment by haas...@gmail.com on 28 Feb 2014 at 4:34

GoogleCodeExporter commented 9 years ago 
You can close the review if you press the little round X left of the title.

Original comment by joao.ei...@gmail.com on 27 Mar 2014 at 1:18

GoogleCodeExporter commented 9 years ago 
There is no little round X to the left of the title under the "incoming 
Reviews" section.

Original comment by haas...@gmail.com on 27 Mar 2014 at 2:52

GoogleCodeExporter commented 9 years ago 
I'ld also appreciate an easy way to close reviews when I am the reviewer.

We use CR a lot, but often submitters do not close them, so my "incoming 
reviews" list grows and grows.

The hack from comment #2 works, but is a bit more work than just a single click 
as it should be.

Original comment by Thomas.J...@gmail.com on 2 Aug 2014 at 5:28